Commenting out Content-Security-Policy_headers to avoid over-riding c… #946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base Branch: 9.x
Note: This PR is made to
doubtfire-lms/doubtfire-webas an upstream contribution after peer review, AppAttack security verification, and mentor approval.Description
This PR updates the internal
nginx.confindoubtfire-webto ensure that security headers (likeX-Frame-Options,Content-Security-Policy, etc.) are not redundantly set or overridden when they are already enforced by the outerproxy-nginx.confin thedoubtfire-deployrepository.This change was originally proposed and peer-reviewed in the ThothTech PR with relevant discussions and final approval from @aNebula. This upstream PR isolates the
nginx.confchange only, without any unrelated deletions (e.g.,package-lock.json), as per mentor's instructions.What was changed
doubtfire-web/nginx.confthat duplicate those set at the reverse proxy level.proxy-nginx.conflayer in the deployment repo.Fixes: Header conflicts and duplication issues between inner and outer NGINX layers.
Reference PRs
Testing Summary
proxy-nginx.confare correctly reflected in browser responses without being overridden by internalnginx.conf.X-Frame-Options,Content-Security-Policy) as verified by peer reviewers and senior reviewer.package-lock.jsonconflict to prevent issues in cross-platform container builds, especially for Windows-based development.Checklist
nginx.confchange includeddoubtfire-lms/9.xbranch