Sprint 41 T1: Remove dead web4_sdk.py + fix v0.26.0 documentation gaps#165
Merged
Conversation
Delete web4_sdk.py (~1500 lines) — async HTTP client referencing nonexistent microservices, not distributed in the wheel, examples deleted in Sprint 36. Delete test_sdk_integration.py (14 tests for the removed module). Fix README.md: version 0.25.0→0.26.0, remove misleading "Client SDK" section, update project structure and test count. Fix quickstart.py docstring version. 2613 tests pass. mypy --strict clean. ruff check + format clean. 0 new files, 2 deleted, 4 modified. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
APPROVED: Sprint 41 T1 aligned. Removes 1506 lines of dead async HTTP SDK code (web4_sdk.py) that was never packaged in the wheel and 14 tests targeting it, plus fixes v0.26.0 documentation gaps (README version, misleading Client SDK section, quickstart docstring). Zero new files, 2 deletions + 4 doc updates. No drift, no scope creep, pure housekeeping. 2613 tests green. |
3 tasks
dp-web4
added a commit
that referenced
this pull request
Apr 18, 2026
Closes the Sprint 36 T1 follow-up: run the quickstart example against the installed wheel so a breaking API change surfaces in CI, not only in the editable-install test matrix. Adds one step to the existing `wheel` job in .github/workflows/sdk-test.yml, immediately after "Verify CLI entry point", invoking `/tmp/web4-wheel-test/bin/python examples/quickstart.py`. The isolated venv already exists from the prior install step; the working directory is already web4-standard/implementation/sdk, so the relative path resolves. No web4/ package changes. No pyproject.toml changes. No version bump. No changes to examples/quickstart.py. 0 new files. Verified locally by reproducing the full CI chain (build wheel, install in fresh venv, `web4 selftest`, `web4 info`, `python examples/quickstart.py`) against v0.26.0 — all pass. Originally proposed as Sprint 40 (PR #164 opened 2026-04-17); renumbered to Sprint 42 per reviewer directive to reflect merge order — Sprint 41 (PR #165) landed on main first. Rebased onto post-Sprint-41 main; doc updates to docs/SPRINT.md and SESSION_FOCUS.md refreshed against current main state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dp-web4
added a commit
that referenced
this pull request
Apr 18, 2026
Closes the Sprint 36 T1 follow-up: run the quickstart example against the installed wheel so a breaking API change surfaces in CI, not only in the editable-install test matrix. Adds one step to the existing `wheel` job in .github/workflows/sdk-test.yml, immediately after "Verify CLI entry point", invoking `/tmp/web4-wheel-test/bin/python examples/quickstart.py`. The isolated venv already exists from the prior install step; the working directory is already web4-standard/implementation/sdk, so the relative path resolves. No web4/ package changes. No pyproject.toml changes. No version bump. No changes to examples/quickstart.py. 0 new files. Verified locally by reproducing the full CI chain (build wheel, install in fresh venv, `web4 selftest`, `web4 info`, `python examples/quickstart.py`) against v0.26.0 — all pass. Originally proposed as Sprint 40 (PR #164 opened 2026-04-17); renumbered to Sprint 42 per reviewer directive to reflect merge order — Sprint 41 (PR #165) landed on main first. Rebased onto post-Sprint-41 main; doc updates to docs/SPRINT.md and SESSION_FOCUS.md refreshed against current main state. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web4_sdk.py(~1500 lines) — async HTTP client for nonexistent microservices, not distributed in the wheel (packages.find.include = ["web4*"]), examples that used it were deleted in Sprint 36tests/test_sdk_integration.py— 14 tests for the removed moduleexamples/quickstart.pydocstring: v0.25.0 → v0.26.0Test plan
mypy --strictclean (25 source files)ruff check web4/ tests/cleanruff format --check web4/ tests/test_*.pyclean🤖 Generated with Claude Code