Adding functionality for Financials API #2
Conversation
godber
left a comment
godber
left a comment
There was a problem hiding this comment.
Please consider the two comments I've made. The first is a simple accept my suggested changes.
I am not the author of the original library so I don't know that this will improve the chances of getting this merged, but it looks good.
To the original author of the module:
I have reviewed the contents of this PR to ensure it doesn't contain anything suspicious, I even skimmed through the newly added financials.py file to make sure it didn't have any suspicious code.
I have not RUN these changes though.
| **bankfind** is a python interface to publically available bank data from the FDIC. | ||
|
|
||
| There are currently, as of 8/11/20, five endpoints that the FDIC has exposed to the public: | ||
| There are currently, as of 4/15/2023, five endpoints that the FDIC has exposed to the public: |
There was a problem hiding this comment.
| There are currently, as of 4/15/2023, five endpoints that the FDIC has exposed to the public: | |
| There are currently, as of 4/15/2023, six endpoints that the FDIC has exposed to the public: |
| search: str = None, | ||
| **kwargs): | ||
| params = self._construct_params(key, filters, search, **kwargs) | ||
| print(urllib.parse.urlencode(params)) |
There was a problem hiding this comment.
Do you really mean to leave this print statement in here? If this project already has a logging facility it might be best to use that or hide this print statement behind a debug environment variable or something.
|
This would close #1 |
|
I've had two other thought here:
@dpguthrie do you have interest in accepting contributions like this PR or are you more interested in us forking? |
2 participants
The FDIC released the financials API after dpguthrie first published this module. I added in the ability to access that API using the same functionality as the Bankfind suite. Because I found Bankfind so helpful, I wanted to provide my changes in case others found them useful.