Skip to content

[Tag] #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Tag] #423

wants to merge 5 commits into from

Conversation

znotfireman
Copy link
Contributor

Implements #36

@znotfireman
Copy link
Contributor Author

i'm a genius and committed to main 😭

EstebenR
EstebenR reviewed Feb 4, 2025
View reviewed changes
dphfox
dphfox reviewed Feb 7, 2025
View reviewed changes
dphfox
dphfox requested changes Feb 10, 2025
View reviewed changes
Copy link
Owner

@dphfox dphfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be unit tested - sorry for the delay in review.

@znotfireman
Copy link
Contributor Author

Isn't unit tests blocked by #421? I don't think it'll make sense writing tests in TestEZ when in the near future, it'll be rewritten completely.

@dphfox
Copy link
Owner

dphfox commented May 10, 2025

It's still wise to unit test new features in the interim because it gives me something to transcribe into the new testing framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EstebenR EstebenR EstebenR left review comments

@dphfox dphfox dphfox requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@znotfireman @dphfox @EstebenR