Skip to content

N2R-31#49

Merged
dprRoberta merged 9 commits intomainfrom
N2R-31
Mar 16, 2026
Merged

N2R-31#49
dprRoberta merged 9 commits intomainfrom
N2R-31

Conversation

@jiawei-lim
Copy link
Copy Markdown
Collaborator

@jiawei-lim jiawei-lim commented Mar 14, 2026

  • Added more example notebooks for testing
  • Performed code clean up on generator and template file code
  • Changed all "print" statements to use logger
  • Remove /generator directory init to prevent import conflicts
  • Implemented test cases for generator,helper, and fast api template file
  • Integrated tests into workflow

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a separate workflow file so it can be manually triggered if needed

Comment thread src/generator.py
logger.info(f"Generated service for notebook: {file}\n")

if __name__ == "__main__":
main() No newline at end of file
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted main to a separate method to improve testability, or else to trigger the tests we will need to call it by importing sys

@jiawei-lim jiawei-lim marked this pull request as draft March 14, 2026 22:12
@jiawei-lim jiawei-lim marked this pull request as ready for review March 16, 2026 17:22
@dprRoberta dprRoberta merged commit 8d39341 into main Mar 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants