Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA stream optimisation #63

Merged
merged 33 commits into from
Jan 15, 2024
Merged

Conversation

envidian
Copy link
Contributor

@envidian envidian commented Jan 9, 2024

  • Adds argument paired_batch_size for specifying fast 1:1 pairing
  • Adds custom handlers for paired_batch_size
  • Defines JSON schema for specifying 1:1 combinations and config
  • Adds use_fast_math support in cmake build (default enabled)
  • Fix memory leaks in Autodock Vina scoring_function reported by Valgrind
  • Fix missing CUDA memory initialisation that causes crashes

The original code flow is retained when paired_batch_size is not specified.
Please refer the README for using the paired_batch_size argument.

This commit reverts previous request, and makes the code aligned with original code-flow.

This reverts commit 8bf2125.
This reverts commit 526cabf.
… dock

- Adds argument paired_batch_size for specifying fast 1:1 pairing
- Adds custom handlers for paired_batch_size
- Defines JSON schema for specifying 1:1 combinations and config
- Adds use_fast_math support in cmake build (default enabled)
- Fix memory leaks in Autodock Vina scoring_function reported by Valgrind
- Fix missing CUDA memory initialisation that causes crashes

The original code flow is retained when paired_batch_size is not specified.
Please refer the README for using the paired_batch_size argument.
@caic99 caic99 requested a review from ysyecust January 10, 2024 02:02
@envidian
Copy link
Contributor Author

Is there any additional information required for this to be reviewed ? @ysyecust Thanks.

@ysyecust
Copy link
Collaborator

ysyecust commented Jan 12, 2024

@envidian Thank you very much for your pull request. If you could add an example of using 1:1 docking in the example folder, I believe it would make it even more perfect and greatly facilitate other users. We would greatly appreciate your consideration of this suggestion.

@envidian
Copy link
Contributor Author

Thank you. I added 5def756 to address the comment. Can you please check ? @ysyecust

Copy link
Member

@caic99 caic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @envidian Thank you for your contribution!
@ysyecust plz review

@ysyecust ysyecust merged commit 92fd4d3 into dptech-corp:main Jan 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants