menu: Makes XBE scanner synchronous. #111
Merged
+139
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaire
commented
Sep 24, 2021
| std::vector<XBEScanner::XBEInfo> const& items) { | ||
| std::list<XBEScanner::XBEInfo> const& items, | ||
| long long duration) { | ||
| (void)duration; |
There was a problem hiding this comment.
Note: I'm piping through duration specifically for ease of debugging, I can pull this out and keep it in a side branch if you'd prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making XBE scanning synchronous until #110 is implemented as the async thread gets starved, leading to multi-minute scan times on a library w/ 160 XBEs.
The downside is that it now takes ~10 extra seconds to get off the initial black screen (presumably this has a direct relationship w/ number of XBEs). The black screen will at least print that a scan is being done so it's not a total user experience disaster :)