Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: Adds very basic theme support. #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

theme: Adds very basic theme support. #112

wants to merge 1 commit into from

Conversation

abaire
Copy link
Contributor

@abaire abaire commented Sep 24, 2021

Puts in the foundation for theme selection.

  • Modifies Makefile to blindly copy anything under Resources/NeXThemes and drops the new_all workaround by adding RESOURCES to TARGET.
  • Adds a Theme JSON parsing class.
  • Moves the default theme resources into a default theme subdir and adds a .json definition file for them.

Some nice followups would be:

  1. Extend Font so the font color can be changed.
  2. Add a menu item to list and select themes.
  3. Add a launcher image so it's clear that NeX hasn't frozen when the user launches a new XBE (we can flash this up and with the current nxdk it should be automatically persisted until the newly launched XBE takes over, though Graphical corruption when using HalQuickRebootRoutine to return to dashboard XboxDev/nxdk#507 will need to be fixed)

@abaire
Copy link
Contributor Author

abaire commented Sep 24, 2021

@kosmas12 I took a stab at putting in a simple foundation that uses JSON files to define themes. Assuming @dracc is OK with this approach, maybe you'd like to rebase your PR and take on the theme directory scanning and menu selection parts?

@abaire abaire force-pushed the theme_support branch 4 times, most recently from bb58e9f to b9803f8 Compare September 30, 2021 23:11
@abaire abaire force-pushed the theme_support branch 6 times, most recently from e21adb1 to a504757 Compare October 8, 2021 15:16
@abaire abaire mentioned this pull request Jan 9, 2022
Draft
MasonT8198
MasonT8198 suggested changes Mar 16, 2025
View reviewed changes
Copy link

@MasonT8198 MasonT8198 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, rudimentary 1080i support may be a decent idea but doesn't have to be within the scope of this PR

Sources/theme.cpp

std::ifstream themeFile(themeFilePath);
nlohmann::json json;
// FIXME: Once nxdk supports C++ Exceptions, this needs to be put in a try-catch block!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supported now is it not?

Includes/theme.hpp
public:
struct MenuTheme {
std::string font;
// TODO: Actually support this in Font.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: font not Font

Sources/config.cpp
{ "mount", nlohmann::json(o.mount) },
#ifdef NXDK
{ "network", nlohmann::json(o.net) },
#endif
{ "logging", nlohmann::json(o.logging) },
{ "homescreenConfig", nlohmann::json(o.homescreen) } };
{ "homescreen", nlohmann::json(o.homescreen) } };
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: specific reason why this was changed? Listing it as config may make it easier for outside devs to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasonT8198 MasonT8198 MasonT8198 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abaire @MasonT8198