Replace <select>s with a custom Combobox component
#1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattBudz
changed the title
<select>s with a custom Combobox component
This reverts commit c84cd3e.
caitmich
reviewed
Apr 3, 2025
caitmich
reviewed
Apr 3, 2025
| } | ||
|
|
||
| if (disabled) { | ||
| $appendedOption.attr('aria-disabled', 'true'); |
There was a problem hiding this comment.
This is to add support for accessibility when an option is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces
<select>elements with a combobox which maintains all the functionality of a standard<select>while also bringing flexible styling options, support for remote data sources, filtering, and pagination.Check List