API add Node properties #1327
Open
API add Node properties #1327
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etdsoft
reviewed
Mar 14, 2025
| @@ -44,7 +44,7 @@ def destroy | |||
| protected | |||
|
|
|||
| def node_params | |||
| params.require(:node).permit(:label, :type_id, :parent_id, :position) | |||
| params.require(:node).permit(:label, :type_id, :parent_id, :position, properties: {}) | |||
There was a problem hiding this comment.
This is important, as using JSON opens a can of worms around validation. If you look at the app's NodesController we stick to raw_properties to let the user submit a "text blob" with the JSON properties, but we then apply strict validation at the model level.
I'd expect for the API flow to follow a very similar pattern.
Co-authored-by: Daniel Martin <[email protected]>
Co-authored-by: Daniel Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change allows users to view Node Properties as part of API Node requests.
Copyright assignment
Check List