fix(cluster_family): Cancel slot migration in case of OOM errors on t… #5000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arget node We should cancel slot migration in case of OOM reported back. Signed-off-by: mkaruza <[email protected]>
BorysTheDev
reviewed
Apr 26, 2025
| @@ -1045,7 +1046,23 @@ void ClusterFamily::DflyMigrateAck(CmdArgList args, SinkReplyBuilder* builder) { | |||
| return builder->SendError(kIdNotFound); | |||
|
|
|||
| if (!migration->Join(attempt)) { | |||
| return builder->SendError("Join timeout happened"); | |||
| // Cleanup migraton that resulted in error | |||
| if (migration->GetState() == MigrationState::C_ERROR) { | |||
There was a problem hiding this comment.
I suggest adding state C_FATAL, to notify control plane that migration can not be finished, and prevent restart migration with error
BorysTheDev
reviewed
Apr 26, 2025
| if (migration->GetState() == MigrationState::C_ERROR) { | ||
| // Restore previous cluster configuration | ||
| server_family_->service().proactor_pool().AwaitFiberOnAll( | ||
| [](util::ProactorBase*) { ClusterConfig::RestorePrevious(); }); |
There was a problem hiding this comment.
we shouldn't change the config, it can be dangerous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arget node
We should cancel slot migration in case of OOM reported back.