feat: add migrated keys statistic #5043
Open
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
requested changes
May 4, 2025
adiholden
reviewed
May 4, 2025
| @@ -240,6 +244,10 @@ void OutgoingMigration::SyncFb() { | |||
| OnAllShards([this](auto& migration) { | |||
| DbSlice& db_slice = namespaces->GetDefaultNamespace().GetCurrentDbSlice(); | |||
| server_family_->journal()->StartInThread(); | |||
|
|
|||
| if (migration) // update stats after fail | |||
There was a problem hiding this comment.
I think that if we fail we should not update this count
It will be clear in monitor to see a drop which means that the migration restarted
There was a problem hiding this comment.
@romange told me that we want to see the progress even with failed attempts
adiholden
reviewed
May 4, 2025
BorysTheDev
force-pushed
the
add_migrated_keys_stats
branch
from
4213f15 to
7e1cf1f
Compare
BorysTheDev
force-pushed
the
add_migrated_keys_stats
branch
from
7e1cf1f to
e632295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5017