refactor: reduce number of cluster logs #5044
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
May 2, 2025
| @@ -462,12 +462,6 @@ void ClusterFamily::DflyCluster(CmdArgList args, const CommandContext& cmd_cntx) | |||
| return builder->SendError("Cluster is disabled. Use --cluster_mode=yes to enable."); | |||
| } | |||
|
|
|||
| if (cntx->conn()) { | |||
| VLOG(2) << "Got DFLYCLUSTER command (" << cntx->conn()->GetClientId() << "): " << args; | |||
There was a problem hiding this comment.
we can just reduce the verbosity level in prod
There was a problem hiding this comment.
To my mind this vlog is extra anycase because we have log info for config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5035