chore(server): Some memory code updates #5379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
changed the title
dranikpg
force-pushed
the
dranikpg-memory-refactor
branch
4 times, most recently
from
5ee2ba1 to
ff39413
Compare
dranikpg
force-pushed
the
dranikpg-memory-refactor
branch
from
ff39413 to
ab2fc7f
Compare
dranikpg
requested review from
romange and
kostasrim
and removed request for
romange
romange
reviewed
Jul 18, 2025
romange
reviewed
Jul 18, 2025
|
also please resolve your branch |
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
dranikpg-memory-refactor
branch
from
79bcb74 to
e2b7c1b
Compare
kostasrim
reviewed
Jul 23, 2025
| } | ||
| } | ||
| return false; | ||
| return any_of(listeners_.begin(), listeners_.end(), |
There was a problem hiding this comment.
I am tempted for the last 2 year to introduce a header algorithm and a function template for each of the most popular standard algorithms:
template<typename C, typename F>
bool any_of(const C& c, F&& f) {
return std::any_of(c.begin(), c.end(), std::forward<F>(f));
}
There was a problem hiding this comment.
#include in a way 🙂
romange
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the points from #5378