feat: add more auxillary strings to the snapshot #5411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
reviewed
Jul 4, 2025
BorysTheDev
reviewed
Jul 4, 2025
BorysTheDev
reviewed
Jul 4, 2025
src/server/server_family.cc
Outdated
| [&] { return LoadRdb(std::string(load_path), existing_keys, &snapshot_id); }); | ||
| if (!load_result.has_value()) | ||
| aggregated_result->first_error = load_result.error(); | ||
| error_code load_result = |
There was a problem hiding this comment.
load_result is error_code, please rename it to result_ec or something else
BorysTheDev
reviewed
Jul 4, 2025
src/server/server_family.cc
Outdated
| else | ||
| aggregated_result->first_error = load_result.error(); | ||
| auto load_func = [=]() mutable { | ||
| error_code load_result = LoadRdb(file, existing_keys, &load_opts); |
There was a problem hiding this comment.
the same, please rename
BorysTheDev
previously approved these changes
Jul 5, 2025
romange
force-pushed
the
Pr1
branch
3 times, most recently
from
1605561 to
fedcc11
Compare
romange
changed the title
This PR adds aux-strings to the header of dfs files. aux-strings do not break compatibility and potentially provide better memory management and consistency checks during the snapshot load. All in all this PR should not change functionality or compatibility with older Dragonfly versons. Signed-off-by: Roman Gershman <[email protected]>
BorysTheDev
reviewed
Jul 10, 2025
Comment on lines
+2481
to
+2484
| uint32_t shard_count; | ||
| if (absl::SimpleAtoi(auxval, &shard_count)) { | ||
| shard_count_ = shard_count; | ||
| } |
There was a problem hiding this comment.
maybe let's do some wrapper, because you do it a lot
BorysTheDev
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds aux-strings to the header of dfs files.
aux-strings do not break compatibility and potentially provide
better memory management and consistency checks during the snapshot load.
All in all this PR should not change functionality or compatibility
with older Dragonfly versons.
Signed-off-by: Roman Gershman [email protected]