fix(pytest): Increase REPLTAKOVER time in test_take_over_seeder #5415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REPLTAKEVER fails when we are replication from 4 proactor threads to 2. Increasing timeout should fix this test. Closes #5360 Signed-off-by: mkaruza <[email protected]>
kostasrim
approved these changes
Jul 4, 2025
| @@ -1294,7 +1294,7 @@ async def info_replication(): | |||
| # Give the seeder a bit of time. | |||
| await asyncio.sleep(3) | |||
| logging.debug("running repltakover") | |||
| await c_replica.execute_command(f"REPLTAKEOVER 10 SAVE") | |||
| await c_replica.execute_command(f"REPLTAKEOVER 30 SAVE") | |||
There was a problem hiding this comment.
So were not robust enough? 😮💨
There was a problem hiding this comment.
It looks that with latest changes in replication and because of this 4->2 we don't takeover in time. I have run several tests on (#5392) with this increase and it seems that it is successful on all runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REPLTAKEVER fails when we are replication from 4 proactor threads to 2. Increasing timeout should fix this test.
Closes #5360