Skip to content

feat(search_family): Introduce SingleBlockRangeResult and TwoBlocksRangeResult #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

feat(search_family): Introduce SingleBlockRangeResult and TwoBlocksRangeResult #5424

merged 2 commits into from
Jul 10, 2025

Conversation

BagritsevichStepan
Copy link
Contributor

@BagritsevichStepan BagritsevichStepan commented Jul 6, 2025 •
edited
Loading

TODO: PR description

Before:

Benchmark Time (ns) CPU (ns) Iterations
BM_SearchSeveralNumericAndTagIndexes/num_docs:10000 345431 345381 2021
BM_SearchSeveralNumericAndTagIndexes/num_docs:100000 3132211 3132008 224
BM_SearchSeveralNumericAndTagIndexes/num_docs:1000000 45877866 45861242 15

After:

Benchmark Time (ns) CPU (ns) Iterations
BM_SearchSeveralNumericAndTagIndexes/num_docs:10000 208139 208107 3352
BM_SearchSeveralNumericAndTagIndexes/num_docs:100000 2642775 2642433 263
BM_SearchSeveralNumericAndTagIndexes/num_docs:1000000 42896361 42891550 17

@BagritsevichStepan BagritsevichStepan self-assigned this Jul 6, 2025
BagritsevichStepan
BagritsevichStepan commented Jul 6, 2025
View reviewed changes
@BagritsevichStepan BagritsevichStepan changed the title feat(search_family): Introduce SingleBlockRangeResult and TwoBlocksRangeResult feat(search_family): Introduce SingleBlockRangeResult and TwoBlocksRangeResult. DRAFT Jul 6, 2025
@BagritsevichStepan BagritsevichStepan force-pushed the search/speed-up-numeric-indexes-range-tree-6 branch from aae6492 to 1c36496 Compare July 9, 2025 20:45
@BagritsevichStepan BagritsevichStepan changed the title feat(search_family): Introduce SingleBlockRangeResult and TwoBlocksRangeResult. DRAFT feat(search_family): Introduce SingleBlockRangeResult and TwoBlocksRangeResult Jul 9, 2025
@BagritsevichStepan BagritsevichStepan force-pushed the search/speed-up-numeric-indexes-range-tree-6 branch from 1c36496 to 5e46081 Compare July 9, 2025 21:20
dranikpg
dranikpg approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@dranikpg dranikpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't rush with refactoring index result because we can simplify it - single/two blocks range results are simply a union operation on two filtered block lists - which should be a task solved by the index result itself

@BagritsevichStepan BagritsevichStepan merged commit 602bf8e into dragonflydb:main Jul 10, 2025
10 checks passed
@BagritsevichStepan BagritsevichStepan deleted the search/speed-up-numeric-indexes-range-tree-6 branch July 10, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dranikpg dranikpg dranikpg approved these changes

Assignees

@BagritsevichStepan BagritsevichStepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BagritsevichStepan @dranikpg