tools: Add scripts and supporting files to generate os packge repo #5923
Conversation
abhijat
force-pushed
the
abhijat/feat/os-package-repo
branch
from
345a8e7 to
908c864
Compare
abhijat
force-pushed
the
abhijat/feat/os-package-repo
branch
6 times, most recently
from
3ec5052 to
55f874d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
abhijat
force-pushed
the
abhijat/feat/os-package-repo
branch
from
37a60f7 to
248307d
Compare
abhijat
changed the title
abhijat
force-pushed
the
abhijat/feat/os-package-repo
branch
2 times, most recently
from
b321dee to
3caca5d
Compare
abhijat
force-pushed
the
abhijat/feat/os-package-repo
branch
3 times, most recently
from
7862f97 to
b223363
Compare
abhijat
force-pushed
the
abhijat/feat/os-package-repo
branch
from
b223363 to
36b9a26
Compare
tools/packaging/osrepos/README.md
Outdated
| Another option would be to use the components feature of apt repositories in the sources file we ask users to install, | ||
| but then the versions would need | ||
| to be hardcoded in the sources file and the user would have | ||
| to update the file with each new release whcih makes for a bad user experience. As of now users wanting older packages |
There was a problem hiding this comment.
nit (typo)
whcih -> which
| gcloud storage rm ${{ secrets.GCP_PACKAGES_BUCKET }}/** | ||
| gcloud storage rsync $SiteRoot ${{ secrets.GCP_PACKAGES_BUCKET }} --recursive --delete-unmatched-destination-objects |
There was a problem hiding this comment.
I don't see the fail states processing. As far as I understand, we can reach this step even if we have a broken package. I think we have to go to the next step only if the previous one succeeded.
Could you please test it? Try to break one of the previous steps.
There was a problem hiding this comment.
Do you mean if a previous step fails, deploy should fail, right?
If any step fails then the job will fail and the next steps will not be tried, this has also happened during the development of this PR many times, but I will confirm it.
There was a problem hiding this comment.
Do you mean if a previous step fails, deploy should fail, right?
If any step fails then the job will fail and the next steps will not be tried, this has also happened during the development of this PR many times, but I will confirm it.
Yes, I want to make sure that we will not deploy a broken package if something went wrong on one of the previous steps.
There was a problem hiding this comment.
tried it here https://github.com/dragonflydb/dragonfly/actions/runs/19426024186/job/55573645544 with commit b3d098e and it failed early
Signed-off-by: Abhijat Malviya <[email protected]>
Signed-off-by: Abhijat Malviya <[email protected]>
abhijat
force-pushed
the
abhijat/feat/os-package-repo
branch
2 times, most recently
from
b3d098e to
857f3b0
Compare
|
lgtm |
Adds scripts and action to generate OS specific packaging for debian and redhat based linux distros (deb and rpm files).
Both repositories are available at https://packages.dragonflydb.io/
The steps in the github action are:
The workflow is currently triggered manually, in a follow up PR it can be triggered on a new release.