Skip to content

fix to inGroupsOf array function #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbarrus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix to inGroupsOf array function #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions asx/src/asx/array/inGroupsOf.as
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
package asx.array
{
/**
*
*
*/
public function inGroupsOf(iterable:Object, size:int):Array
{
var i:int = 0;
var group:Array = [];
var groups:Array = [group];

for each (var item:Object in iterable)
var i:int = size;
var group:Array;
var groups:Array = [];
for each(var item:Object in iterable)
{
group[group.length] = item;
i++;

if (i == size)
if( i == size )
{
i = 0;
i = 0;
group = [];
groups[groups.length] = group;
}
}

group[group.length] = item;
i++;
}

return groups;
}
}
}
15 changes: 15 additions & 0 deletions asx_test/src/asx/array/InGroupsOfTest.as
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package asx.array
{
import org.flexunit.assertThat;
import org.hamcrest.collection.array;
import org.hamcrest.object.equalTo;

public class InGroupsOfTest
Expand All @@ -11,5 +12,19 @@ package asx.array
var values:Array = [1, 2, 3, 4, 5, 6, 7];
assertThat(inGroupsOf(values, 3), equalTo([[1, 2, 3], [4, 5, 6], [7]]));
}

[Test]
public function inGroupsOf_withArray_evenLength_shouldSplitItemsIntoArraysOfGivenSize():void
{
var values:Array = [1, 2, 3, 4, 5, 6];
assertThat(inGroupsOf(values, 3), equalTo([[1, 2, 3], [4, 5, 6]]));
}

[Test]
public function inGroupsOf_withArray_shouldSplitItemsIntoArraysOfGivenSize_1():void
{
var values:Array = [1, 2, 3, 4, 5, 6];
assertThat(inGroupsOf(values, 1), equalTo([[1], [2], [3], [4], [5], [6]]));
}
}
}