Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings #145

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix clippy warnings #145

merged 1 commit into from
Aug 1, 2024

Conversation

GnomedDev
Copy link
Contributor

This leaves one clippy warning, large_enum_variant, triggered by ServerHandshake, but I'm opening a followup to fix that.

lulf
lulf approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GnomedDev
Copy link
Contributor Author

Can you merge this, #146, and #147 in then? It seems like the CI failures are caused by http.sandbox.drogue.cloud no longer existing. @lulf

@lulf lulf merged commit 29943a3 into drogue-iot:main Aug 1, 2024
1 check failed
@GnomedDev GnomedDev deleted the fix-clippy branch August 1, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lulf lulf lulf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @lulf