feat(usenet): improve error propagation in UsenetReader (#180) #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a download pipe is closed due to an error (e.g., article not found), the reader now reliably receives the specific error instead of losing it. Changes: - Add explicit downloadErr field to segment struct for error storage - Add SetDownloadError/GetDownloadError methods with first-write-wins semantics - Create errorAwareReader wrapper to check stored errors before/after reads - Update GetReader() to capture errors from skip logic (previously discarded) - Update safeWriter.CloseWithError() to store error before closing pipes - Add comprehensive tests for error propagation scenarios This ensures that errors like "article not found" are properly propagated to the reader and wrapped in DataCorruptionError for proper handling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a download pipe is closed due to an error (e.g., article not found), the reader now reliably receives the specific error instead of losing it.
Changes:
This ensures that errors like "article not found" are properly propagated to the reader and wrapped in DataCorruptionError for proper handling.
🤖 Generated with Claude Code