Fix/nzb cleanup #63
Merged
Fix/nzb cleanup #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify RegisterCorruptedFile to set status to pending with high priority and maxed retries. - Update UpdateFileHealth to use max_retries - 1 and high priority when noRetry is true (playback errors). - Update metadata filesystem to report playback errors as pending in DB to trigger repair cycle. - Add regression test for playback failure behavior in health_repository_test.go. - Fix scan error in tests by updating priority column type to INTEGER in test setup.
…gured - Move ErrFallbackNotConfigured to shared internal/errors package to avoid cycle. - Update PostProcessor interface to return error from HandleFailure. - Update HandleFailure to return ErrFallbackNotConfigured when fallback is disabled. - Ensure service stays in 'failed' status and logs skipping when fallback is not used.
fix: downgrade nntppool and simplify stale items reset (javi11#173)
Fix/fallback not configured
Fix/playback failure repair
refactor(health): remove dead code and fix Go anti-patterns (javi11#179)
Previously, the health repair process would fail if 'health.library_dir' was not configured, even though it was only used for logging in the Sonarr rescan logic. This change makes it optional, preventing repair failures for users with default configurations.
Previously, the last library sync result was stored only in memory, causing it to be lost on restart. This resulted in the 'Next Scan' field showing 'Automatic sync not configured' until a manual scan was triggered. This change adds a system_state table to persist the result. Also fixed frontend type mismatches and added missing deletion stats to the UI.
- Fix wrong import via /api/import/file - Clean up the NZB file(from /.nzbs) after successful processing - Fix missing codes into frontend
… 'origin/fix/sonarr-library-dir-optional'
…tend Fix(bugs): import file and frontend
…for both watch dir and nzbdav
…ndencies - Simplify usenet_reader.go by removing unnecessary type assertions for safeWriter which already implements Close() and CloseWithError() - Fix formatting issues in sabnzbd_types.go (indentation, trailing newline) - Convert if-else chains to switch statements in instances/manager.go and validation/segments.go for cleaner code - Update nntppool/v2 from v2.3.0 to v2.3.2 - Update rapidyenc dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ate dependencies" This reverts commit ce82ccb.
…t loss on restart
Fixed a bug in RAR archive validation where AES-encrypted files were being validated with incorrect parameters, causing misleading error messages about file size mismatches. The issue was that the code was: 1. Manually calculating the encrypted size using aes.EncryptedSize() 2. Passing this encrypted size to ValidateSegmentsForFile 3. But passing Encryption_NONE as the encryption type This caused ValidateSegmentsForFile to treat the encrypted size as the decrypted size, leading to validation failures and confusing error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.