Skip to content

fix problem with slash in branch name on Windows #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nebulon42
Copy link
Contributor

In 3d1b6f1 OS specific handling was added for line endings and path separators when executing Git commands.

This was over-generalizing the problem because the response of a Git command can also include a branch name and if that branch name would contain a slash (e.g. feature/my-feature) then this would be changed to a backslash on Windows which does not work.

I have removed the path separator handling from the Git command output and moved it instead to the changed file processing location.

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nebulon42 nebulon42 marked this pull request as draft July 29, 2025 09:53
@nebulon42 nebulon42 marked this pull request as ready for review July 29, 2025 09:55
@joshafeinberg joshafeinberg merged commit 829a9a2 into dropbox:main Aug 18, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slashes in current branch name being replaced with backslashes on windows
3 participants