Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax microphone permissions checking on Windows. #825

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Relax microphone permissions checking on Windows. #825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/os/windows_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ void VerifyMicrophonePermissions(std::promise<bool>& micPromise)
// General Microphone enable/disable (applies to all users)
wxRegKey localMachineMicrophoneKey(wxRegKey::HKLM, "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\CapabilityAccessManager\\ConsentStore\\microphone");

// "Let desktop apps access your microphone" (applies on a per-user basis, requires above to be enabled)
wxRegKey currentUserNonPackagedKey(wxRegKey::HKCU, "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\CapabilityAccessManager\\ConsentStore\\microphone\\NonPackaged");

bool localMachineMicrophoneAllowed = false;
if (localMachineMicrophoneKey.Exists())
{
Expand All @@ -43,15 +40,7 @@ void VerifyMicrophonePermissions(std::promise<bool>& micPromise)
localMachineMicrophoneAllowed = regValue == "Allow";
}

bool currentUserNonPackagedAllowed = false;
if (currentUserNonPackagedKey.Exists())
{
wxString regValue;
currentUserNonPackagedKey.QueryValue("Value", regValue, true);
currentUserNonPackagedAllowed = regValue == "Allow";
}

microphonePermissionsGranted = localMachineMicrophoneAllowed && currentUserNonPackagedAllowed;
microphonePermissionsGranted = localMachineMicrophoneAllowed;
micPromise.set_value(microphonePermissionsGranted);
}

Expand Down