fix: duplicate DRP call #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangquocvietuet
requested review from
JanLewDev,
trungnotchung,
winprn and
magnified103
as code owners
Signed-off-by: Sacha Froment <[email protected]>
sfroment
force-pushed
the
fix/duplicate-drp-call
branch
from
b6e40e3 to
b42cc8b
Compare
sfroment
reviewed
Feb 5, 2025
Co-authored-by: Sacha Froment <[email protected]>
Flamegraph.com reportCreated by Flamegraph.com Github Action |
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
sfroment
approved these changes
Feb 12, 2025
| const callerName = new Error().stack?.split("\n")[2]?.trim().split(" ")[1]; | ||
| if (callerName?.startsWith("DRPObject.resolveConflicts")) { | ||
| const startWithQuery = (propKey as string).startsWith("query_"); |
There was a problem hiding this comment.
How does propKey differ from callerName in this context?
| @@ -226,6 +227,11 @@ export class DRPObject implements ObjectPb.DRPObjectBase { | |||
|
|
|||
| this.vertices.push(vertex); | |||
| this._notify("callFn", [vertex]); | |||
|
|
|||
| if (!isACL) Object.assign(this.drp as DRP, drp); | |||
| else Object.assign(this.acl as ObjectACL, drp); | |||
There was a problem hiding this comment.
Why didn’t the old code include these lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved: #404