feat: expose the peerId that created the operations #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamegraph.com reportCreated by Flamegraph.com Github Action |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
2 tasks
trungnotchung
requested review from
JanLewDev,
winprn,
magnified103,
d-roak,
anhnd350309 and
sfroment
as code owners
winprn
reviewed
Mar 13, 2025
packages/object/src/index.ts
Outdated
Comment on lines
359
to
367
| if (!caller) { | ||
| throw new Error("Caller is undefined"); | ||
| } | ||
| if (target.context) { | ||
| target.context.caller = caller; | ||
| } else { | ||
| throw new Error("Target does not have a context to update."); | ||
| } | ||
|
|
There was a problem hiding this comment.
why you mark the caller as optional then enforce checks like this? I think it's better to force on the function params
There was a problem hiding this comment.
i did it because peerId can be undefined in _computeDRP. Agree it's better to check it there before calling _applyOperation.
* origin: fix: tsconfig for interval discovery (#564)
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
Signed-off-by: Sacha Froment <[email protected]>
JanLewDev
approved these changes
Mar 14, 2025
packages/types/src/drp.ts
Outdated
Comment on lines
29
to
32
| /** | ||
| * The context metadata for a request. | ||
| */ | ||
| context?: DrpRuntimeContext; |
There was a problem hiding this comment.
I would put it below semantics type
sfroment
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
DRPRuntimeContextand added to theIDRP.drp.contextbefore applying an opeartion to the drp.Related Issues and PRs
Added/updated tests?
Additional Info
add instructions or screenshots on what you might think is relevant or instructions on how to manually test it
[optional] Do we need to perform any post-deployment tasks?