feat: expose the peerId that created the operations #551

trungnotchung · 2025-03-10T11:46:50Z

What type of PR is this?

Feature

Description

Created new interface DRPRuntimeContext and added to the IDRP.
Updated the DRPObject to update drp.context before applying an opeartion to the drp.
Updated all examples and blueprints.
Updated relevant tests and added new tests for that.

Steps to access the peerId of the operation creator in a function:

You need to add context: DrpRuntimeContext as an attribute of your DRP.
If you want to get the peerId that created the operations in a function, you can access it using this.context.caller.

For example, we can use this to verify the creator of the grant operation has admin permission:

grant(peerId: string, group: ACLGroup): void {
    if (!this.query_isAdmin(this.context.caller)) {
			throw new Error("Only admin peers can grant permissions.");
    }
    // remaining code
}

Related Issues and PRs

Closes: [FEATURE] - Expose the peerId that created the operations #489

Added/updated tests?

Yes

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

github-actions · 2025-03-10T11:47:27Z

Flamegraph.com report

flamegraph.pprof

See in flamegraph.com

Created by Flamegraph.com Github Action

github-actions · 2025-03-10T11:47:53Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	85.99%	3156 / 3670
🔵	Statements	85.99%	3156 / 3670
🔵	Functions	83.85%	270 / 322
🔵	Branches	85.18%	828 / 972

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/object/src/index.ts	90%	80.95%	100%	90%	171-172, 176, 208-209, 224-225, 232-234, 255-256, 269-272, 301-302, 313-314, 354-355, 436-440, 448-449, 454-455, 466-467, 475-476, 491-492, 510-511, 519-520, 537-538, 551-552, 609-614, 629, 647-648, 658-659
packages/object/src/acl/index.ts	91.47%	82.75%	100%	91.47%	57-58, 79, 85-86, 94, 102, 158-161
packages/types/src/drp.ts	0%	100%	100%	0%	7-15

Generated in workflow #2436 for commit 8c5a924 by the Vitest Coverage Report Action

packages/object/src/index.ts

* origin: feat!: handle async DRP function (#555) feat: interval-drp-discovery (#528)

* origin: fix: tsconfig for interval discovery (#564)

Signed-off-by: Sacha Froment <[email protected]>

JanLewDev

otherwise lgtm

packages/types/src/drp.ts

anhnd350309

lgtm

* main: chore(deps): bump @opentelemetry/sdk-trace-web from 1.30.1 to 2.0.0 (#585) fix!: testcase handle sync message correctly (#588) feat: expose the peerId that created the operations (#551) Fix: testcase incorrect (#557) chore(deps-dev): bump eslint-import-resolver-typescript from 3.8.7 to 4.2.0 (#583) fix: add log config to createObject option to be passed down to finality store (#574) feat: add logger template (#576)

@trung

* origin: chore(deps): bump @opentelemetry/sdk-trace-web from 1.30.1 to 2.0.0 (#585) fix!: testcase handle sync message correctly (#588) feat: expose the peerId that created the operations (#551) Fix: testcase incorrect (#557) chore(deps-dev): bump eslint-import-resolver-typescript from 3.8.7 to 4.2.0 (#583) fix: add log config to createObject option to be passed down to finality store (#574) feat: add logger template (#576) chore: add @trung to keychain code owners (#562) refactor!: remove public credential (#563)

@trung

* origin: fix: log_config pass down to disco interval (#590) feat(object): drpobject become generic (#565) chore(deps): bump @opentelemetry/sdk-trace-web from 1.30.1 to 2.0.0 (#585) fix!: testcase handle sync message correctly (#588) feat: expose the peerId that created the operations (#551) Fix: testcase incorrect (#557) chore(deps-dev): bump eslint-import-resolver-typescript from 3.8.7 to 4.2.0 (#583) fix: add log config to createObject option to be passed down to finality store (#574) feat: add logger template (#576) chore: add @trung to keychain code owners (#562) refactor!: remove public credential (#563) fix(network): 🐛 isDialable shall ret true event when no callback is passed (#559) feat: add hashgraph visualizer (#512)

…t-bootstrap * origin: fix(interval-discovery)!: now use a != topic in order not to have many invalid operation logs (#589) feat!: restrict set key access (#582) fix: log_config pass down to disco interval (#590) feat(object): drpobject become generic (#565) chore(deps): bump @opentelemetry/sdk-trace-web from 1.30.1 to 2.0.0 (#585) fix!: testcase handle sync message correctly (#588) feat: expose the peerId that created the operations (#551) Fix: testcase incorrect (#557) chore(deps-dev): bump eslint-import-resolver-typescript from 3.8.7 to 4.2.0 (#583) fix: add log config to createObject option to be passed down to finality store (#574) feat: add logger template (#576)

trungnotchung added 4 commits March 10, 2025 14:45

add context to drp interface

15c2c27

Merge branch 'main' into feat/expose-peerid

0f9be7c

Merge branch 'main' into feat/expose-peerid

50c6028

update all examples and blueprints

87f2f23

trungnotchung mentioned this pull request Mar 11, 2025

refactor: update linearization to return vertices #552

Merged

2 tasks

trungnotchung added 8 commits March 12, 2025 17:57

Merge branch 'main' into feat/expose-peerid

cc63536

Merge branch 'main' into feat/expose-peerid

7fea7d2

update context.peerid before apply operation

ba0ba7c

Merge branch 'main' into feat/expose-peerid

23acaf5

Merge branch 'main' into feat/expose-peerid

1f05104

add tests

4ec83c9

rename peerId to caller

787e26c

update type

ba95270

trungnotchung marked this pull request as ready for review March 13, 2025 14:36

trungnotchung requested review from JanLewDev, winprn, magnified103, d-roak, anhnd350309 and sfroment as code owners March 13, 2025 14:36

update naming

07f35ea

winprn reviewed Mar 13, 2025

View reviewed changes

packages/object/src/index.ts Outdated Show resolved Hide resolved

sfroment and others added 6 commits March 13, 2025 17:36

Merge remote-tracking branch 'origin' into feat/expose-peerid

c99f61f

* origin: feat!: handle async DRP function (#555) feat: interval-drp-discovery (#528)

Merge remote-tracking branch 'origin' into feat/expose-peerid

10ed8a6

* origin: fix: tsconfig for interval discovery (#564)

chore: following merge this test need to be async

7fcf6fc

Signed-off-by: Sacha Froment <[email protected]>

chore: make context optional

baa5f97

Signed-off-by: Sacha Froment <[email protected]>

chore: test caller on async call

6e25597

Signed-off-by: Sacha Froment <[email protected]>

make context optional

ed63670

trungnotchung added 2 commits March 14, 2025 15:19

fix lint

f6531c5

fix undefined caller

ea57c29

JanLewDev approved these changes Mar 14, 2025

View reviewed changes

packages/types/src/drp.ts Outdated Show resolved Hide resolved

apply suggestion

077b7eb

sfroment requested a review from winprn March 17, 2025 07:02

sfroment approved these changes Mar 17, 2025

View reviewed changes

anhnd350309 approved these changes Mar 18, 2025

View reviewed changes

Merge branch 'main' into feat/expose-peerid

8c5a924

sfroment approved these changes Mar 18, 2025

View reviewed changes

sfroment merged commit a674c88 into main Mar 18, 2025
15 checks passed

sfroment deleted the feat/expose-peerid branch March 18, 2025 14:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: expose the peerId that created the operations #551

feat: expose the peerId that created the operations #551

trungnotchung commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

JanLewDev left a comment

anhnd350309 left a comment

feat: expose the peerId that created the operations #551

feat: expose the peerId that created the operations #551

Conversation

trungnotchung commented Mar 10, 2025 • edited Loading

What type of PR is this?

Description

Related Issues and PRs

Added/updated tests?

Additional Info

[optional] Do we need to perform any post-deployment tasks?

github-actions bot commented Mar 10, 2025 • edited Loading

Flamegraph.com report

github-actions bot commented Mar 10, 2025 • edited Loading

Coverage Report

JanLewDev left a comment

Choose a reason for hiding this comment

anhnd350309 left a comment

Choose a reason for hiding this comment

trungnotchung commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading