Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): 🐛 isDialable shall ret true event when no callback is passed #559

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

sfroment
Copy link
Member

What type of PR is this?

  • Bug Fix

Description

If no callback is passed yet we still are dialable we shall return true

Related Issues and PRs

Added/updated tests?

  • Yes

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Mar 12, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link

github-actions bot commented Mar 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.27% 3130 / 3628
🔵 Statements 86.27% 3130 / 3628
🔵 Functions 84.16% 271 / 322
🔵 Branches 85.31% 825 / 967
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/network/src/node.ts 75.65% 68.65% 55.55% 75.65% 94, 214-215, 250-253, 259-261, 289-291, 294-296, 300-302, 309-310, 314-325, 328-335, 338-344, 347-352, 355-356, 363-366, 369-372, 381-382, 392-393, 397-409, 426-430
Generated in workflow #2406 for commit 12627b1 by the Vitest Coverage Report Action

@sfroment sfroment force-pushed the fix/isDialable-callback branch from 9db5e1f to 12627b1 Compare March 14, 2025 08:40
@sfroment sfroment merged commit 0d4166f into main Mar 14, 2025
15 checks passed
@sfroment sfroment deleted the fix/isDialable-callback branch March 14, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - isDialable always return false if user don't pass callback
2 participants