fix(network): 🐛 isDialable shall ret true event when no callback is passed #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamegraph.com reportCreated by Flamegraph.com Github Action |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
anhnd350309
reviewed
Mar 13, 2025
sfroment
requested review from
JanLewDev,
trungnotchung,
winprn and
anhnd350309
Signed-off-by: Sacha Froment <[email protected]>
sfroment
force-pushed
the
fix/isDialable-callback
branch
from
9db5e1f to
12627b1
Compare
sfroment
added a commit
that referenced
this pull request
Mar 19, 2025
* origin: fix: log_config pass down to disco interval (#590) feat(object): drpobject become generic (#565) chore(deps): bump @opentelemetry/sdk-trace-web from 1.30.1 to 2.0.0 (#585) fix!: testcase handle sync message correctly (#588) feat: expose the peerId that created the operations (#551) Fix: testcase incorrect (#557) chore(deps-dev): bump eslint-import-resolver-typescript from 3.8.7 to 4.2.0 (#583) fix: add log config to createObject option to be passed down to finality store (#574) feat: add logger template (#576) chore: add @trung to keychain code owners (#562) refactor!: remove public credential (#563) fix(network): 🐛 isDialable shall ret true event when no callback is passed (#559) feat: add hashgraph visualizer (#512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
If no callback is passed yet we still are dialable we shall return true
Related Issues and PRs
isDialablealways return false if user don't pass callback #522Added/updated tests?
Additional Info
add instructions or screenshots on what you might think is relevant or instructions on how to manually test it
[optional] Do we need to perform any post-deployment tasks?