Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object): drpobject become generic #565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sfroment
Copy link
Member

Signed-off-by: Sacha Froment [email protected]

feat: generic

Signed-off-by: Sacha Froment [email protected]

What type of PR is this?

  • Refactor

Description

Make the drp the drp object type

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: justify why you didn't add tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Mar 14, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link

github-actions bot commented Mar 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.28% 3134 / 3632
🔵 Statements 86.28% 3134 / 3632
🔵 Functions 84.16% 271 / 322
🔵 Branches 85.31% 825 / 967
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/node/src/handlers.ts 87.4% 76.47% 93.75% 87.4% 96-98, 115, 123-124, 127-129, 131-133, 148-153, 161-163, 180-182, 216, 230-232, 238-240, 274, 284-286, 291-293, 337, 346-351, 382, 386, 391, 403-404, 491-493
packages/node/src/index.ts 76.77% 73.07% 64.7% 76.77% 87-88, 91-95, 98-104, 107-111, 114-120, 133-134, 159-160, 192-194, 196-198
packages/node/src/operations.ts 97.75% 94.73% 100% 97.75% 83-84
packages/node/src/store/object.ts 90.24% 90% 100% 90.24% 46-49
packages/object/src/index.ts 91.32% 81.56% 100% 91.32% 165-166, 170, 202-203, 218-219, 226-228, 246-247, 260-263, 292-293, 304-305, 345-346, 421-425, 429-430, 435-436, 446-447, 455-456, 482-483, 491-492, 515-516, 602-603, 613-614
packages/object/src/finality/index.ts 95.71% 92.68% 100% 95.71% 74-75, 123-124, 164-165
packages/tracer/src/index.ts 92% 88.67% 70% 92% 57-60, 104-105, 107-108, 110-111, 143-144, 146-147, 149-150
packages/types/src/finality.ts 0% 0% 0% 0%
packages/types/src/node.ts 0% 0% 0% 0%
packages/types/src/object.ts 0% 0% 0% 0%
Generated in workflow #2409 for commit ba9e1ae by the Vitest Coverage Report Action

@sfroment sfroment force-pushed the feat/generic branch 2 times, most recently from c08d7f6 to cc2cff7 Compare March 14, 2025 08:46
Signed-off-by: Sacha Froment <[email protected]>

feat: generic

Signed-off-by: Sacha Froment <[email protected]>
Copy link
Member

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants