Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object): drpobject become generic #565

Merged
merged 2 commits into from
Mar 18, 2025
Merged

feat(object): drpobject become generic #565

merged 2 commits into from
Mar 18, 2025

Conversation

sfroment
Copy link
Member

Signed-off-by: Sacha Froment [email protected]

feat: generic

Signed-off-by: Sacha Froment [email protected]

What type of PR is this?

  • Refactor

Description

Make the drp the drp object type

Related Issues and PRs

  • Related: #
  • Closes: #

Added/updated tests?

  • No, because why: justify why you didn't add tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

Copy link

github-actions bot commented Mar 14, 2025

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

Copy link

github-actions bot commented Mar 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.38% 3143 / 3681
🔵 Statements 85.38% 3143 / 3681
🔵 Functions 83.85% 270 / 322
🔵 Branches 84.57% 817 / 966
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/node/src/handlers.ts 80.71% 65.78% 93.75% 80.71% 96-98, 115, 123-124, 127-129, 131-133, 148-153, 161-163, 180-182, 194, 216, 230-232, 238-240, 251-252, 274, 284-286, 291-293, 299-300, 314-318, 322-339, 346-351, 382, 386, 391, 403-404, 491-493
packages/node/src/index.ts 77.21% 76.92% 64.7% 77.21% 87-88, 91-95, 98-104, 107-111, 114-120, 136-137, 161-162, 194-196, 198-200
packages/node/src/operations.ts 100% 100% 100% 100%
packages/node/src/store/object.ts 90.24% 90% 100% 90.24% 46-49
packages/object/src/index.ts 89.98% 81.08% 100% 89.98% 169-170, 174, 206-207, 222-223, 230-232, 253-254, 267-270, 299-300, 311-312, 352-353, 434-438, 446-447, 452-453, 464-465, 473-474, 489-490, 508-509, 517-518, 535-536, 549-550, 607-612, 627, 645-646, 656-657
packages/object/src/finality/index.ts 95.71% 92.68% 100% 95.71% 73-74, 122-123, 163-164
packages/tracer/src/index.ts 92% 88.67% 70% 92% 59-62, 106-107, 109-110, 112-113, 145-146, 148-149, 151-152
packages/types/src/finality.ts 0% 0% 0% 0%
packages/types/src/node.ts 0% 0% 0% 0%
packages/types/src/object.ts 0% 0% 0% 0%
Generated in workflow #2459 for commit 0a0c4df by the Vitest Coverage Report Action

@sfroment sfroment force-pushed the feat/generic branch 2 times, most recently from c08d7f6 to cc2cff7 Compare March 14, 2025 08:46
Signed-off-by: Sacha Froment <[email protected]>

feat: generic

Signed-off-by: Sacha Froment <[email protected]>
Copy link
Member

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* origin:
  chore(deps): bump @opentelemetry/sdk-trace-web from 1.30.1 to 2.0.0 (#585)
  fix!: testcase handle sync message correctly (#588)
  feat: expose the peerId that created the operations (#551)
  Fix: testcase incorrect (#557)
  chore(deps-dev): bump eslint-import-resolver-typescript from 3.8.7 to 4.2.0 (#583)
  fix: add log config to createObject option to be passed down to finality store (#574)
  feat: add logger template (#576)
  chore: add @trung to keychain code owners (#562)
  refactor!: remove public credential (#563)
@sfroment sfroment merged commit 63574e6 into main Mar 18, 2025
15 checks passed
@sfroment sfroment deleted the feat/generic branch March 18, 2025 14:06
sfroment added a commit that referenced this pull request Mar 19, 2025
* origin:
  fix: log_config pass down to disco interval (#590)
  feat(object): drpobject become generic (#565)
  chore(deps): bump @opentelemetry/sdk-trace-web from 1.30.1 to 2.0.0 (#585)
  fix!: testcase handle sync message correctly (#588)
  feat: expose the peerId that created the operations (#551)
  Fix: testcase incorrect (#557)
  chore(deps-dev): bump eslint-import-resolver-typescript from 3.8.7 to 4.2.0 (#583)
  fix: add log config to createObject option to be passed down to finality store (#574)
  feat: add logger template (#576)
  chore: add @trung to keychain code owners (#562)
  refactor!: remove public credential (#563)
  fix(network): 🐛 isDialable shall ret true event when no callback is passed (#559)
  feat: add hashgraph visualizer (#512)
sfroment added a commit that referenced this pull request Mar 19, 2025
* origin:
  fix(interval-discovery)!: now use a != topic in order not to have many invalid operation logs (#589)
  feat!: restrict set key access (#582)
  fix: log_config pass down to disco interval (#590)
  feat(object): drpobject become generic (#565)
sfroment added a commit that referenced this pull request Mar 19, 2025
…t-bootstrap

* origin:
  fix(interval-discovery)!: now use a != topic in order not to have many invalid operation logs (#589)
  feat!: restrict set key access (#582)
  fix: log_config pass down to disco interval (#590)
  feat(object): drpobject become generic (#565)
  chore(deps): bump @opentelemetry/sdk-trace-web from 1.30.1 to 2.0.0 (#585)
  fix!: testcase handle sync message correctly (#588)
  feat: expose the peerId that created the operations (#551)
  Fix: testcase incorrect (#557)
  chore(deps-dev): bump eslint-import-resolver-typescript from 3.8.7 to 4.2.0 (#583)
  fix: add log config to createObject option to be passed down to finality store (#574)
  feat: add logger template (#576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants