-
Notifications
You must be signed in to change notification settings - Fork 255
Variation title generate event #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.x-2.x
Are you sure you want to change the base?
Variation title generate event #707
Conversation
Latest changes from commerce
Upstream updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test module, like commerce_product_test
even, which subscribes to this event. If the product's SKU is GENERATE_TEST
(or something) it'll react and change the title. So we can prove it works and document the feature via tests.
6be1d5c
to
b8a7444
Compare
I'll work on these tests ASAP btw, sorry for leaving this out there for so long. |
Sorry for the stray merge commits, there are no changes from those merges represented here.
This is an attempt to resolve https://www.drupal.org/node/2846895 by adding a new event that's dispatched after generating the variation title, before saving it to the variation.