fix(qa): remove dead calibration-metrics hook path (fixes #123) - #128
Open
jakobtfaber wants to merge 1 commit into
Open
fix(qa): remove dead calibration-metrics hook path (fixes #123)#128jakobtfaber wants to merge 1 commit into
jakobtfaber wants to merge 1 commit into
Conversation
Co-Authored-By: Jakob Faber <jfaber@caltech.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The post-calibration pipeline hook
extract_calibration_metricswas operating on aCalibrationMetricsdataclass as if it were adict, causing anAttributeErrorwhenever a bandpass table resolved (#123). The wholeCalibrationMetricsRecord→hook_calibration_complete→ingest_calibration_metrics→update_calibration_trendingpath was already unused: the production QA backend now lives indsa110_continuum.qa.calibration_qualityand the dashboard usesvalidate_caltable_quality.This PR deletes the dead code and makes
qa/pipeline_hooks.pya minimal hook module, retaining a no-ophook_ese_detection_completeplaceholder thatphotometry/ese_detection.pyalready attempts to call when ESE candidates are found.Changes
dsa110_continuum/qa/pipeline_hooks.pywith a small module docstring andhook_ese_detection_complete(). RemovedCalibrationMetricsRecord,extract_calibration_metrics,_find_caltables_for_ms,_compute_quality_score,_extract_residual_metrics,ingest_calibration_metrics,hook_calibration_complete,update_calibration_trending, andquery_calibration_trending.dsa110_continuum/qa/__init__.pyto expose onlyhook_ese_detection_completeand removed outdated Phase 3.1 docstring references.Verification
make test-cloud PYTHON=/home/ubuntu/.venv-dsa110-312/bin/pythonpasses (200 passed).ruff check dsa110_continuum/qa/pipeline_hooks.py dsa110_continuum/qa/__init__.pyis clean.Closes #123.