fix(calibration): fail safe on ambiguous bad-pol MS coherence - #132
Draft
jakobtfaber wants to merge 1 commit into
Draft
fix(calibration): fail safe on ambiguous bad-pol MS coherence#132jakobtfaber wants to merge 1 commit into
jakobtfaber wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MS-coherence fallback for single-polarization failure detection could assign the clean receptor label under amplitude-imbalanced failures. Real-MS validation showed two contributing problems:
casa_tablesreturns visibility cells as(rows, correlations, channels), but the fallback treated them as(rows, channels, correlations), so frequency channels were being analyzed as polarization indices.This change corrects the axis handling, computes phase coherence per baseline, and makes the fallback abstain when it cannot safely label a receptor. The phase-table path remains the required method for amplitude-imbalanced antennas.
Changes
(n_rows, n_pol, n_chan).amplitude_imbalanced_antennasso callers can identify antennas requiring phase-table analysis.Validation
tests/test_detect_bad_polarizations.py tests/test_run_pre_calibration_flagging.py: 17 passed.tests/test_bad_pol_wiring_smoke.py --run-slow: 1 passed against a generated UVH5 converted to a real CASA MS.ruff checkon the three changed files: passed.git diff --check: passed.Closes #73.