BREAKING CHANGE: xWindowsUpdate: Added automatic release with a new CI pipeline #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johlju
changed the title
johlju
added
the
breaking change
gaelcolas
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
This looks good overall, but some big changes are hard to tell.
Integration testing (or people testing in prod) will be the true test ;)
Gael
Reviewed 54 of 54 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
johlju
added a commit
that referenced
this pull request
Mar 21, 2020
…I pipeline (#94) - xWindowsUpdate - BREAKING CHANGE: Removed the deprecated resource `xMicrosoftUpdate`- - Added automatic release with a new CI pipeline. - Moved the `Set-StrictMode` so that it is used during testing only and not during runtime. - Removed the helper function `Trace-Message` and using the `Write-Verbose` directly instead. - The helper function `New-InvalidArgumentException` was replaced by its equivalent in the module DscResource.Common. xWindowsUpdateAgent - Added Retry logic to known transient errors (issue #24). - Removed the `$PSCmdlet.ShouldProcess` calls from code since DSC does not support interactive actions. - No longer defaults to output verbose messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Added
Changed
Set-StrictModeso that it is used during testing only andnot during runtime.
Trace-Messageand using theWrite-Verbosedirectly instead.
New-InvalidArgumentExceptionwas replaced byits equivalent in the module DscResource.Common.
$PSCmdlet.ShouldProcesscalls from code since DSC does notsupport interactive actions.
Removed
xMicrosoftUpdateThis Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is