Feature/min items #306
Open
Feature/min items #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully allow for empty arrays to be caught by minItems = 1
herman1vdb
approved these changes
Aug 16, 2018
Contributor
Author
|
Agreed, I should have split it, but was in a hurry to get this into my project. I'm usually better about this type of stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What changes does this PR include (check all that apply)?
[x] Bugfix
Related issue / current behavior
When generating a formArray, there is an empty formControl generated. This results in the minItems validator returning true when minItems=1, even though the array is empty/missing.
New behavior
minItems now correctly catches empty/missing arrays
Does this PR introduce a breaking change?
[x] Yes
[ ] No
This PR corrects a typo, changing defautWidgetOptions to defaultWidgetOptions.