feat(windows): request folder permissions when traversing path (#269)

deno.json

@@ -39,7 +39,7 @@
     "@std/io": "jsr:@std/[email protected]",
     "@std/path": "jsr:@std/[email protected]",
     "@std/streams": "jsr:@std/[email protected]",
-    "which": "jsr:@david/which@0.3",
+    "which": "jsr:@david/which@^0.4.1",
     "which_runtime": "jsr:@david/[email protected]"
   }
 }

dprint.json

@@ -13,9 +13,8 @@
     "lineWidth": 120
   },
   "excludes": [
-    "**/node_modules",
-    "**/*-lock.json",
-    "**/target",
+    "target",
+    "npm",
     "**/*.generated.js"
   ],
   "plugins": [

mod.test.ts

@@ -714,7 +714,8 @@ Deno.test("env should be clean slate when clearEnv is set", async () => {
   }
   Deno.env.set("DAX_TVAR", "123");
   try {
-    const text = await $`deno eval 'console.log("DAX_TVAR: " + Deno.env.get("DAX_TVAR"))'`.clearEnv().text();
+    const text = await $`deno eval --no-config 'console.log("DAX_TVAR: " + Deno.env.get("DAX_TVAR"))'`.clearEnv()
+      .text();
     assertEquals(text, "DAX_TVAR: undefined");
   } finally {
     Deno.env.delete("DAX_TVAR");
@@ -725,7 +726,7 @@ Deno.test("clearEnv + exportEnv should not clear out real environment", async ()
   Deno.env.set("DAX_TVAR", "123");
   try {
     const text =
-      await $`deno eval 'console.log("VAR: " + Deno.env.get("DAX_TVAR") + " VAR2: " + Deno.env.get("DAX_TVAR2"))'`
+      await $`deno eval --no-config 'console.log("VAR: " + Deno.env.get("DAX_TVAR") + " VAR2: " + Deno.env.get("DAX_TVAR2"))'`
         .env("DAX_TVAR2", "shake it shake")
         .clearEnv()
         .exportEnv()

mod.ts

@@ -40,6 +40,7 @@ import { wasmInstance } from "./src/lib/mod.ts";
 import { createPath, Path } from "./src/path.ts";
 import { RequestBuilder, withProgressBarFactorySymbol } from "./src/request.ts";
 import { outdent } from "./src/vendor/outdent.ts";
+import { denoWhichRealEnv } from "./src/shell.ts";
 
 export type { Delay, DelayIterator } from "./src/common.ts";
 export { TimeoutError } from "./src/common.ts";
@@ -510,7 +511,7 @@ export interface $BuiltInProperties<TExtras extends ExtrasObject = {}> {
    * or the specified number of retries (`count`) is hit.
    */
   withRetries<TReturn>(opts: RetryOptions<TReturn>): Promise<TReturn>;
-  /** Re-export of `deno_which` for getting the path to an executable. */
+  /** Re-export of `jsr:@david/which` for getting the path to an executable. */
   which: Which;
   /** Similar to `which`, but synchronously. */
   whichSync: WhichSync;
@@ -601,14 +602,14 @@ const helperObject = {
     if (commandName.toUpperCase() === "DENO") {
       return Promise.resolve(Deno.execPath());
     } else {
-      return which(commandName);
+      return which(commandName, denoWhichRealEnv);
     }
   },
   whichSync(commandName: string) {
     if (commandName.toUpperCase() === "DENO") {
       return Deno.execPath();
     } else {
-      return whichSync(commandName);
+      return whichSync(commandName, denoWhichRealEnv);
     }
   },
 };

src/shell.ts

@@ -1215,7 +1215,15 @@ async function resolveCommand(unresolvedCommand: UnresolvedCommand, context: Con
   };
 }
 
-const realEnvironment = new DenoWhichRealEnvironment();
+class WhichEnv extends DenoWhichRealEnvironment {
+  requestPermission(folderPath: string) {
+    Deno.permissions.requestSync({
+      name: "read",
+      path: folderPath,
+    });
+  }
+}
+export const denoWhichRealEnv = new WhichEnv();
 
 export async function whichFromContext(commandName: string, context: {
   getVar(key: string): string | undefined;
@@ -1226,10 +1234,11 @@ export async function whichFromContext(commandName: string, context: {
   }
   return await which(commandName, {
     os: Deno.build.os,
-    stat: realEnvironment.stat,
+    stat: denoWhichRealEnv.stat,
     env(key) {
       return context.getVar(key);
     },
+    requestPermission: denoWhichRealEnv.requestPermission,
   });
 }