Skip to content

Remove simplejson #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove simplejson #3

wants to merge 5 commits into from

Conversation

asmundg
Copy link

@asmundg asmundg commented Oct 25, 2014

Requests will actually raise a ValueError, meaning that using simplejson here is both an undeclared dependency and wrong.

The tests require #2 to run.

Åsmund Grammeltvedt added 4 commits October 25, 2014 11:18
This demonstrates erroneous usage of simplejson.
Requests will actually raise a ValueError, meaning that using simplejson
here is both an undeclared dependency and wrong.
@dsoprea
Copy link
Owner

dsoprea commented Oct 26, 2014

After removing the environments that I don't support, as well as the "-r{toxinidir}/requirements.txt" dependency (which shouldn't ever be valid), I still get a certain type of failure with all remaining environments. This is the failure for python27:

$ tox
GLOB sdist-make: /Users/dustin/build/etcd.asmundg/setup.py
py27 inst-nodeps: /Users/dustin/build/etcd.asmundg/.tox/dist/etcd-2.0.8.zip
py27 runtests: PYTHONHASHSEED='2124068991'
py27 runtests: commands[0] | py.test --junitxml=xunit_test_report.xml --cov /Users/dustin/build/etcd.asmundg/.tox/py27/lib/python2.7/site-packages/etcd --cov-report term-missing
WARNING:test command found but not installed in testenv
  cmd: /usr/local/bin/py.test
  env: /Users/dustin/build/etcd.asmundg/.tox/py27
Maybe forgot to specify a dependency?
usage: py.test [options] [file_or_dir] [file_or_dir] [...]
py.test: error: unrecognized arguments: --cov --cov-report term-missing
ERROR: InvocationError: '/usr/local/bin/py.test --junitxml=xunit_test_report.xml --cov /Users/dustin/build/etcd.asmundg/.tox/py27/lib/python2.7/site-packages/etcd --cov-report term-missing'
___________________________________________________________________________________________________________________________ summary ____________________________________________________________________________________________________________________________
ERROR:   py27: commands failed

What am I missing?

@asmundg
Copy link
Author

asmundg commented Oct 26, 2014

You're missing the requirements.txt file you pointed out. :)

@dsoprea
Copy link
Owner

dsoprea commented Oct 26, 2014

The requirements file is in the resources directory, but you were referring
to it in two separate locations.

I don't understand.
On Oct 26, 2014 3:37 AM, "Åsmund Grammeltvedt" [email protected]
wrote:

You're missing the requirements.txt file you pointed out. :)


Reply to this email directly or view it on GitHub
#3 (comment)
.

@asmundg
Copy link
Author

asmundg commented Oct 26, 2014

I didn't want to mess too much with your layout, so I added a separate
requirements.txt including the test requirements (pytest,
pytest-coverage), which I then forgot to add.

The latest commit includes it and tox now runs correctly from a clean
branch.

Åsmund Grammeltvedt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants