bpftool unpin#1 #8
Conversation
WalkthroughThis update introduces two new functions. In Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant M as Map (do_unpin)
participant C as Common (do_unpin_path)
participant E as ebpf_object_unpin
participant L as Logger (p_err)
U->>M: Invoke "unpin" command with path
M->>M: Validate argument count
M->>C: Call do_unpin_path(path)
C->>E: Call ebpf_object_unpin(path)
E-->>C: Return error code (err)
alt Error occurred (err != 0)
C->>L: Log error with p_err (includes strerror(errno))
end
C-->>M: Return err
alt No error and json_output enabled
M->>U: Output null JSON value via jsonw_null
end
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/map.c (1)
1443-1481: 🛠️ Refactor suggestionThe unpin command is missing from the help text.
The new unpin command should be added to the help text to ensure users are aware of this functionality.
fprintf(stderr, "Usage: %1$s %2$s { show | list } [MAP]\n" " %1$s %2$s create FILE type TYPE key KEY_SIZE value VALUE_SIZE \\\n" " entries MAX_ENTRIES name NAME [flags FLAGS] \\\n" " [inner_map MAP] [dev NAME]\n" " %1$s %2$s dump MAP\n" " %1$s %2$s update MAP [key DATA] [value VALUE] [UPDATE_FLAGS]\n" " %1$s %2$s lookup MAP [key DATA]\n" " %1$s %2$s getnext MAP [key DATA]\n" " %1$s %2$s delete MAP key DATA\n" " %1$s %2$s pin MAP FILE\n" + " %1$s %2$s unpin FILE\n" " %1$s %2$s event_pipe MAP [cpu N index M]\n" " %1$s %2$s peek MAP\n" " %1$s %2$s push MAP value VALUE\n" " %1$s %2$s pop MAP\n" " %1$s %2$s enqueue MAP value VALUE\n" " %1$s %2$s dequeue MAP\n" " %1$s %2$s freeze MAP\n" " %1$s %2$s help\n"
🧹 Nitpick comments (1)
src/map.c (1)
1230-1240: Indentation inconsistency with the rest of the codebase.The function looks good functionally, but the indentation uses 4 spaces while the rest of the file uses tabs. This creates inconsistency in the code style.
-static int do_unpin(int argc, char **argv) -{ - int err; - if (argc != 1) { // Expect exactly one argument: the pinned file path - return BAD_ARG(); - } - err = do_unpin_path(*argv); - if (!err && json_output) - jsonw_null(json_wtr); - return err; -} +static int do_unpin(int argc, char **argv) +{ + int err; + if (argc != 1) { // Expect exactly one argument: the pinned file path + return BAD_ARG(); + } + err = do_unpin_path(*argv); + if (!err && json_output) + jsonw_null(json_wtr); + return err; +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/common.c(1 hunks)src/map.c(2 hunks)
🧰 Additional context used
🧬 Code Definitions (2)
src/common.c (1)
src/main.h (1)
p_err(89-89)
src/map.c (4)
src/main.h (1)
argc(131-131)src/common.c (1)
do_unpin_path(283-292)src/json_writer.h (1)
jsonw_null(47-47)src/json_writer.c (1)
jsonw_null(212-215)
🔇 Additional comments (2)
src/common.c (1)
283-292: LGTM! The unpin function implementation looks clean and follows the codebase's error handling pattern.The function correctly handles errors and provides a meaningful error message using
p_err()withstrerror(errno)to show the actual reason for failure.src/map.c (1)
1493-1493: LGTM! Command registration looks good.The command is properly registered in the commands array, making it available for users.
adding unpin functionality to bpftool
Summary by CodeRabbit