Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover C++20 in CI (fixing char8_t-related problem there). #1437

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

anforowicz
Copy link
Contributor

This is the CI coverage of C++20 (and other C++ versions) that was discussed in #1432. Let me start as a "draft" PR, to quickly check if the new CI steps actually pass.

@anforowicz anforowicz marked this pull request as ready for review February 9, 2025 16:22
@anforowicz
Copy link
Contributor Author

Okay, I think this is ready for a review - can you PTAL?

(I see that it would have detected a regression that I tried introducing in #1438 as an ad-hoc test.)

.github/workflows/ci.yml Show resolved Hide resolved
@anforowicz
Copy link
Contributor Author

Oh, but I guess now I need to check why C++11 fails...

@anforowicz
Copy link
Contributor Author

Hmmm... I guess C++11 is just not supported at this point - e.g.:

 cargo:warning=src/blobstore.cc: In member function 'org::blobstore::BlobMetadata org::blobstore::BlobstoreClient::metadata(uint64_t) const':
  cargo:warning=src/blobstore.cc:61:23: error: use of 'auto' in lambda parameter declaration only available with '-std=c++14' or '-std=gnu++14'
  cargo:warning=   61 |                   [&](auto &t) { metadata.tags.emplace_back(t); });
  cargo:warning=      |                       ^~~~

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 4ff8185 into dtolnay:master Feb 9, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants