π‘οΈ Sentinel: [HIGH] Fix prototype pollution in aiRouter#64
π‘οΈ Sentinel: [HIGH] Fix prototype pollution in aiRouter#64
Conversation
Added `__proto__`, `constructor`, and `prototype` to the blocked list in `mergeExtraBody` within `backend/src/services/aiRouter.ts` to prevent prototype poisoning from user-supplied `extraBody` parameters.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: The
mergeExtraBodyfunction inbackend/src/services/aiRouter.tsshallow-merged user-supplied JSON from API requests directly into a system-constructed payload object. It iterated over properties without sanitizing standard prototype injection keys. An attacker could provide__proto__,constructor, orprototypein their request'sextraBody, allowing them to mutate the prototype chain of the request payload or surrounding objects.π― Impact: If exploited, this could lead to Denial of Service (DoS) or logic bypasses during AI API request construction and routing.
π§ Fix: Added
__proto__,constructor, andprototypeto the explicitly blocked set of keys that are not copied over from the user'sextraBodyobject into the request payload.β Verification: Verified by executing the project's Vitest test suite (
npx vitest run) to ensure no regressions. The change successfully blocks assignment of prototype keys during the iteration insidemergeExtraBody.PR created automatically by Jules for task 9122693872965937823 started by @dttdrv