Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix prototype pollution in aiRouter#64

Open
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-prototype-pollution-9122693872965937823
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix prototype pollution in aiRouter#64
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-prototype-pollution-9122693872965937823

Conversation

@dttdrv
Copy link
Copy Markdown
Owner

@dttdrv dttdrv commented Mar 23, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The mergeExtraBody function in backend/src/services/aiRouter.ts shallow-merged user-supplied JSON from API requests directly into a system-constructed payload object. It iterated over properties without sanitizing standard prototype injection keys. An attacker could provide __proto__, constructor, or prototype in their request's extraBody, allowing them to mutate the prototype chain of the request payload or surrounding objects.
🎯 Impact: If exploited, this could lead to Denial of Service (DoS) or logic bypasses during AI API request construction and routing.
πŸ”§ Fix: Added __proto__, constructor, and prototype to the explicitly blocked set of keys that are not copied over from the user's extraBody object into the request payload.
βœ… Verification: Verified by executing the project's Vitest test suite (npx vitest run) to ensure no regressions. The change successfully blocks assignment of prototype keys during the iteration inside mergeExtraBody.


PR created automatically by Jules for task 9122693872965937823 started by @dttdrv

Added `__proto__`, `constructor`, and `prototype` to the blocked list
in `mergeExtraBody` within `backend/src/services/aiRouter.ts` to
prevent prototype poisoning from user-supplied `extraBody` parameters.
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant