Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix session tokens persisted in localStorage#65

Open
dttdrv wants to merge 1 commit intomasterfrom
jules-sentinel-session-token-fix-3966926279880142809
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix session tokens persisted in localStorage#65
dttdrv wants to merge 1 commit intomasterfrom
jules-sentinel-session-token-fix-3966926279880142809

Conversation

@dttdrv
Copy link
Copy Markdown
Owner

@dttdrv dttdrv commented Mar 24, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The sessionStore fallback in src/core/storage/local.ts defaulted to localStorage when sessionStorage was unavailable. This caused sensitive session tokens (access_token, refresh_token) to be persisted to disk.
🎯 Impact: Any XSS or malicious extension could steal tokens and impersonate the user from persistent disk storage, increasing the risk of exfiltration via physical access.
πŸ”§ Fix: Replaced the localStorage fallback with an isolated InMemoryStorage instance that implements the Storage interface.
βœ… Verification: Ran npx vitest run and verified that no regressions were introduced. Confirmed tests passed and new logic is in place. Added a sentinel journal entry.


PR created automatically by Jules for task 3966926279880142809 started by @dttdrv

Replaced the localStorage fallback for sessionStorage with an InMemoryStorage implementation. This prevents sensitive tokens from being persisted to disk when sessionStorage is unavailable.
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant