π‘οΈ Sentinel: [HIGH] Fix session tokens persisted in localStorage#65
π‘οΈ Sentinel: [HIGH] Fix session tokens persisted in localStorage#65
Conversation
Replaced the localStorage fallback for sessionStorage with an InMemoryStorage implementation. This prevents sensitive tokens from being persisted to disk when sessionStorage is unavailable.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: The
sessionStorefallback insrc/core/storage/local.tsdefaulted tolocalStoragewhensessionStoragewas unavailable. This caused sensitive session tokens (access_token,refresh_token) to be persisted to disk.π― Impact: Any XSS or malicious extension could steal tokens and impersonate the user from persistent disk storage, increasing the risk of exfiltration via physical access.
π§ Fix: Replaced the
localStoragefallback with an isolatedInMemoryStorageinstance that implements theStorageinterface.β Verification: Ran
npx vitest runand verified that no regressions were introduced. Confirmed tests passed and new logic is in place. Added a sentinel journal entry.PR created automatically by Jules for task 3966926279880142809 started by @dttdrv