Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix Option Injection#69

Open
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-option-injection-16557289786198474322
Open

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix Option Injection#69
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-option-injection-16557289786198474322

Conversation

@dttdrv
Copy link
Copy Markdown
Owner

@dttdrv dttdrv commented Mar 25, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Option Injection (Command Injection) via array-based arguments. The mainFile parameter was passed directly to the latexmk binary via array-based argument passing (Command::new("latexmk").arg(&req.main_file)) without validating if the filename started with a hyphen (-). This allowed attackers to provide filenames like -shell-escape or -interaction=..., which latexmk would interpret as command-line flags.
🎯 Impact: Attackers could inject arbitrary options into the latexmk command execution, potentially escaping the intended execution context or gaining unintended execution capabilities on the compile worker.
πŸ”§ Fix: Modified the parsing of mainFile in CompileQueueService.enqueue to strictly validate and reject any filename starting with a - by throwing a 400 Bad Request error. Added a critical learning entry to .jules/sentinel.md.
βœ… Verification: Ran the full project test suite using Vitest to confirm no regressions and manually verified the mainFile logic via code inspection.


PR created automatically by Jules for task 16557289786198474322 started by @dttdrv

@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant