🛡️ Sentinel: [CRITICAL] Fix command injection in compile queue#70
🛡️ Sentinel: [CRITICAL] Fix command injection in compile queue#70
Conversation
Adds a security check to explicitly reject `mainFile` parameters that start with a hyphen to prevent Command Option Injection (such as `-shell-escape`) when executed by `latexmk` within the Rust compilation worker.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Command Option Injection. The
mainFileparameter was passed unvalidated into a payload meant for the Rust compilation worker. The worker passesmainFileas an argument tolatexmk, making it vulnerable to Option Injection if a filename starts with a hyphen (e.g.,-shell-escape). This bypasses intended compilation restrictions and potentially allows remote code execution.🎯 Impact: Attackers could inject arbitrary command options into the
latexmkexecution context on the server, potentially allowing code execution, bypassing security policies, or modifying system state.🔧 Fix: Explicitly validate the
mainFilestring inbackend/src/services/compileQueue.tsto reject any input that starts with-before it reaches thespawnor Rust binary execution layer.✅ Verification: Ensure the test suite passes (
npx vitest run). Sending an API request withmainFile: "-shell-escape"will now be immediately blocked by the backend API with a 400 Bad Request error.PR created automatically by Jules for task 10344884033043598611 started by @dttdrv