Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Command Option Injection#72

Open
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-command-option-injection-1816402237701966379
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Command Option Injection#72
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-command-option-injection-1816402237701966379

Conversation

@dttdrv
Copy link
Copy Markdown
Owner

@dttdrv dttdrv commented Mar 26, 2026

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The mainFile parameter in backend/src/services/compileQueue.ts was passed to the latexmk command via the Rust compile worker without validating if it looked like a flag (i.e., starting with a -).
🎯 Impact: An attacker could craft a compile job where the mainFile was a malicious flag like -shell-escape, potentially leading to remote command execution on the worker server, depending on the LaTeX distribution configuration.
πŸ”§ Fix: Added a check to explicitly reject mainFile inputs that start with a hyphen.
βœ… Verification: Validated that inputs starting with - are correctly rejected with a 400 Bad Request HttpError. Tests were run and code review was completed to verify safety.


PR created automatically by Jules for task 1816402237701966379 started by @dttdrv

…orker

This patch ensures that user-provided `mainFile` values in the compilation queue cannot start with a hyphen (`-`). This prevents Command Option Injection attacks where a malicious user could pass options (like `-shell-escape`) to the `latexmk` external command spawned by the Rust compilation worker.
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant