π‘οΈ Sentinel: [HIGH] Fix Command Option Injection#74
π‘οΈ Sentinel: [HIGH] Fix Command Option Injection#74
Conversation
- Prevent `mainFile` starting with a hyphen to mitigate Command Option Injection via `latexmk`. - Documented finding in Sentinel's journal.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: The
mainFileparameter inbackend/src/services/compileQueue.tswas passed to thelatexmkbinary via the Rust worker without validation. IfmainFilestarted with a hyphen (-), it could be treated as a flag (e.g.,-shell-escape), leading to Command Option Injection and potentially Remote Code Execution (RCE).π― Impact: Attackers could inject arbitrary compiler flags into the latex worker execution, allowing arbitrary code execution or file access outside the scope of the project.
π§ Fix: Added explicit validation to reject
mainFileinputs starting with a hyphen incompileQueue.ts.β Verification: Tested against existing unit tests using
npx vitest run. Evaluated via code review.PR created automatically by Jules for task 15129120703110867285 started by @dttdrv