π‘οΈ Sentinel: [CRITICAL/HIGH] Fix prototype pollution in AI extra body#75
π‘οΈ Sentinel: [CRITICAL/HIGH] Fix prototype pollution in AI extra body#75
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
mergeExtraBodyfunction inbackend/src/services/aiRouter.tsshallow-copied properties from a user-providedextraBodyobject into apayloadobject without checking for sensitive keys. This allowed attackers to potentially override prototype properties like__proto__,constructor, orprototypeif the input payload contained these maliciously crafted properties.π― Impact: Prototype pollution can lead to application logic bypass, unexpected behavior, or Denial of Service (DoS) attacks depending on how the polluted properties are subsequently used.
π§ Fix: Added explicit blocklist checks for
__proto__,constructor, andprototypein the loop that mergesextraBodyproperties.β Verification: Run
npx vitest runand confirm all tests pass. Ad-hoc testing confirms prototype properties are not transferred to the target object.PR created automatically by Jules for task 16236615034221000408 started by @dttdrv