π‘οΈ Sentinel: [CRITICAL] Fix command option injection#77
π‘οΈ Sentinel: [CRITICAL] Fix command option injection#77
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command Option Injection in
compileQueue.ts. ThemainFileparameter was used directly in alatexmkshell command via the Rust worker without sanitizing malicious option flags.π― Impact: Attackers could potentially pass malicious flags (like
-shell-escape) to thelatexmkbinary to execute arbitrary commands.π§ Fix: Explicitly validated that the
mainFileinput does not start with a hyphen (-).β Verification: Confirmed via tests and manual source inspection. Added learning to
.jules/sentinel.md.PR created automatically by Jules for task 4124323496254008622 started by @dttdrv