Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command option injection#77

Open
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-command-option-injection-4124323496254008622
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command option injection#77
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-command-option-injection-4124323496254008622

Conversation

@dttdrv
Copy link
Copy Markdown
Owner

@dttdrv dttdrv commented Mar 28, 2026

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command Option Injection in compileQueue.ts. The mainFile parameter was used directly in a latexmk shell command via the Rust worker without sanitizing malicious option flags.
🎯 Impact: Attackers could potentially pass malicious flags (like -shell-escape) to the latexmk binary to execute arbitrary commands.
πŸ”§ Fix: Explicitly validated that the mainFile input does not start with a hyphen (-).
βœ… Verification: Confirmed via tests and manual source inspection. Added learning to .jules/sentinel.md.


PR created automatically by Jules for task 4124323496254008622 started by @dttdrv

@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant