π‘οΈ Sentinel: [CRITICAL/HIGH] Fix Prototype Pollution vulnerability#79
π‘οΈ Sentinel: [CRITICAL/HIGH] Fix Prototype Pollution vulnerability#79
Conversation
Modified mergeExtraBody to block `__proto__`, `constructor`, and `prototype` keys during object merging to prevent potential prototype pollution vulnerabilities.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: The
mergeExtraBodyfunction directly assigned keys from a user-provided JSON object (extraBody) ontopayload. Although it skipped some restricted keys likemodel, it did not sanitize against__proto__,constructor, orprototype, leaving it vulnerable to prototype pollution if malicious input is supplied.π― Impact: Attackers could manipulate prototype chains leading to application crashes, logic bypasses, or potential remote code execution (RCE) depending on how properties are accessed elsewhere.
π§ Fix: Explicitly added
"__proto__","constructor", and"prototype"to theblockedset inmergeExtraBodybefore merging properties.β Verification: Ran
npx vitest runtests and confirmed everything functions as expected with the mitigation in place. Code review also verified this is an industry standard and completely safe practice.PR created automatically by Jules for task 15947103853043525928 started by @dttdrv