Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix command option injection#82

Open
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-command-option-injection-11608252281840772252
Open

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix command option injection#82
dttdrv wants to merge 1 commit intomasterfrom
sentinel/fix-command-option-injection-11608252281840772252

Conversation

@dttdrv
Copy link
Copy Markdown
Owner

@dttdrv dttdrv commented Mar 30, 2026

🚨 Severity: CRITICAL/HIGH
πŸ’‘ Vulnerability: The mainFile parameter in CompileQueueService was passed directly as a positional argument to latexmk within the Rust compile worker. A user could supply a file name starting with a hyphen (e.g., -shell-escape or -output-directory=...), which latexmk would interpret as an executable flag instead of a file name.
🎯 Impact: Unsanitized file names could allow an attacker to inject arbitrary flags into latexmk, leading to remote code execution (via -shell-escape) or arbitrary file operations (via -output-directory).
πŸ”§ Fix: Added a validation check in backend/src/services/compileQueue.ts to reject any request.mainFile that starts with a hyphen (-).
βœ… Verification: Ran npx vitest run to ensure tests passed. The validation throws a standard 400 HttpError when a hyphen is provided.


PR created automatically by Jules for task 11608252281840772252 started by @dttdrv

@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant