🛡️ Sentinel: [CRITICAL] Fix Command Option Injection#85
🛡️ Sentinel: [CRITICAL] Fix Command Option Injection#85
Conversation
Add validation to `backend/src/services/compileQueue.ts` to reject `mainFile` inputs starting with a hyphen. This prevents arbitrary options from being injected into the latexmk execution within the compile worker.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Command Option Injection. The
mainFileparameter was dynamically injected into external execution arrays natively without verification.🎯 Impact: Attackers could specify inputs such as
-shell-escapecausing arbitrary script executions or access within the underlying system.🔧 Fix: Validated
mainFileparameter strictly, rejecting any arguments that start with a hyphen (-).✅ Verification: Ensure the test cases run and inputs like
-main.texor-shell-escapeare appropriately thrown out asHttpError.PR created automatically by Jules for task 3186802811596026716 started by @dttdrv