⚡ bolt: [performance improvement] refactor PhotoCarousel visibility checking#28
⚡ bolt: [performance improvement] refactor PhotoCarousel visibility checking#28
Conversation
Deploying personal-website with
|
| Latest commit: |
c2a520a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://861864ba.personal-website-5ns.pages.dev |
| Branch Preview URL: | https://bolt-photocarousel-opt-11436.personal-website-5ns.pages.dev |
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: replaced synchronous
getBoundingClientRect()inPhotoCarousel.isInView()with a cachedisVisibleproperty updated by anIntersectionObserver.🎯 Why: previously,
getBoundingClientRect()was called on every keydown event (e.g. arrow keys) to check if the carousel was visible. this caused layout thrashing and reduced responsiveness.📊 Impact: eliminates synchronous layout calculations during high-frequency keydown events, reducing frame drops and improving responsiveness.
🔬 Measurement: verify that pressing arrow keys while the carousel is visible or not visible works correctly without any synchronous layout warnings in devtools.
PR created automatically by Jules for task 11436224521773904632 started by @dttdrv