Conversation
replace synchronous `getBoundingClientRect` call in `PhotoCarousel.isInView` with an async `IntersectionObserver` cache property to stop layout thrashing on rapid keydown events.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying personal-website with
|
| Latest commit: |
9415bd0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://767491e6.personal-website-5ns.pages.dev |
| Branch Preview URL: | https://bolt-photocarousel-intersect.personal-website-5ns.pages.dev |
1 participant
💡 what: replaced the synchronous
getboundingclientrect()call inphotocarousel.isinview()with an asynchronousintersectionobserverthat updates anisvisibleproperty.🎯 why: frequent keyboard events repeatedly query the layout via
getboundingclientrect, which causes layout thrashing and drops frames. caching visibility removes this main-thread bottleneck.📊 impact: removes forced synchronous layout recalculations when pressing arrow keys or using mouse wheel, leading to smoother interactions.
🔬 measurement: tested keyboard arrow interaction while carousel is visible to confirm functionality remains perfectly intact.
PR created automatically by Jules for task 6363537933059272971 started by @dttdrv